[firefly] [PATCH 2/3] Staging: rtl8192u: fix functions that should not be declared extern

Teodora Baluta teobaluta at gmail.com
Sat Oct 12 01:22:06 EEST 2013


These functions are already marked extern in the header file

* drivers/staging/rtl8192u/r819xU_phy.c:1716:13: warning: function
'InitialGainOperateWorkItemCallBack' with external linkage has definition
* drivers/staging/rtl8192u/r819xU_cmdpkt.c:84:18: warning: function
'cmpk_message_handle_tx' with external linkage has definition
* drivers/staging/rtl8192u/r819xU_cmdpkt.c:596:12: warning: function
'cmpk_message_handle_rx' with external linkage has definition

Signed-off-by: Teodora Baluta <teobaluta at gmail.com>
---
 drivers/staging/rtl8192u/r819xU_cmdpkt.c |   10 +++++-----
 drivers/staging/rtl8192u/r819xU_phy.c    |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
index 5614401..670c79a 100644
--- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
+++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
@@ -81,9 +81,9 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen)
  *	05/06/2008	amy		porting from windows code.
  *
  *---------------------------------------------------------------------------*/
-extern rt_status cmpk_message_handle_tx(struct net_device *dev,
-					u8 *codevirtualaddress,
-					u32 packettype, u32 buffer_len)
+rt_status cmpk_message_handle_tx(struct net_device *dev,
+				 u8 *codevirtualaddress,
+				 u32 packettype, u32 buffer_len)
 {
 
 	bool	    rt_status = true;
@@ -593,8 +593,8 @@ static void cmpk_handle_tx_rate_history(struct net_device *dev, u8 *pmsg)
  *  05/06/2008		amy	Create Version 0 porting from windows code.
  *
  *---------------------------------------------------------------------------*/
-extern u32 cmpk_message_handle_rx(struct net_device *dev,
-				  struct ieee80211_rx_stats *pstats)
+u32 cmpk_message_handle_rx(struct net_device *dev,
+			   struct ieee80211_rx_stats *pstats)
 {
 	int			total_length;
 	u8			cmd_length, exe_cnt = 0;
diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
index a6fac08..39cd070 100644
--- a/drivers/staging/rtl8192u/r819xU_phy.c
+++ b/drivers/staging/rtl8192u/r819xU_phy.c
@@ -1713,7 +1713,7 @@ void InitialGain819xUsb(struct net_device *dev,	u8 Operation)
 		queue_delayed_work(priv->priv_wq, &priv->initialgain_operate_wq, 0);
 }
 
-extern void InitialGainOperateWorkItemCallBack(struct work_struct *work)
+void InitialGainOperateWorkItemCallBack(struct work_struct *work)
 {
 	struct delayed_work *dwork = container_of(work, struct delayed_work,
 						  work);
-- 
1.7.10.4



More information about the firefly mailing list