[firefly] [PATCH] CAIF: fix indentation for function arguments

Alexandru Copot alex.mihai.c at gmail.com
Wed Mar 6 21:24:51 EET 2013


On Wed, Mar 6, 2013 at 7:31 PM, Silviu Popescu
<silviupopescu1990 at gmail.com> wrote:
> I was thinking to fix indentation as David Miller suggested[1]. I've tested
> the patch locally by creating another branch and applying the patch to it
> and then checking the results with cat/nano.
> However, the way the body of the patch is listed in the firefly archives or
> if I try to cat the patch file locally second and subsequent lines appear to
> be lined up with the parenthesis not the column immediately after.
> Is there any reason why this should happen?

When you display your patched files with cat or nano you are using your
terminal font. If this is not monospaced then it won't align properly.

On the mailing list I had the same problem. The gmail webmail client
is also using sans fonts. Try to read the email using Thunderbird or other
desktop clients. And always send the patches with git send-email.

Alex


More information about the firefly mailing list