[firefly] [PATCH] net: replace kmalloc and memcpy by kmemdup

[Silviu Popescu]

On Thu, Jul 18, 2013 at 7:22 PM, Valentina Manea
<valentina.manea.m at gmail.com> wrote:
> This patch replaces kmalloc and memcpy usage for
> duplicating a memory region by kmemdup.
>
> Signed-off-by: Valentina Manea <valentina.manea.m at gmail.com>
> ---
>  net/dns_resolver/dns_query.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
> index c32be29..4ac62fb 100644
> --- a/net/dns_resolver/dns_query.c
> +++ b/net/dns_resolver/dns_query.c
> @@ -146,11 +146,10 @@ int dns_query(const char *type, const char *name, size_t namelen,
>         len = upayload->datalen;
>
>         ret = -ENOMEM;
> -       *_result = kmalloc(len + 1, GFP_KERNEL);
> +       *_result = kmemdup(upayload->data, len + 1, GFP_KERNEL);
>         if (!*_result)
>                 goto put;
>
> -       memcpy(*_result, upayload->data, len + 1);
>         if (_expiry)
>                 *_expiry = rkey->expiry;
>
> --
> 1.7.10.4

Looks good overall, with the following two nitpicks regarding the
commit message:
- "replaces ... with kmemdup"
- if you found this with something automated like make coccicheck, you
should mention that in the commit message

--
Silviu Popescu