[firefly] [PATCH v2] x86/pci: checkpatch.pl cleanup

Vlad Dogaru ddvlad at herebedragons.ro
Fri Jul 12 18:44:17 EEST 2013


On Fri, Jul 12, 2013 at 06:19:56PM +0300, Valentina Manea wrote:
> On Fri, Jul 12, 2013 at 6:14 PM, Daniel Baluta <daniel.baluta at gmail.com> wrote:
> > On Fri, Jul 12, 2013 at 6:04 PM, Valentina Manea <valentina.manea.m at gmail.com> wrote:
> >> @@ -250,9 +250,10 @@ int __init pci_mrst_init(void)
> >>  static void pci_d3delay_fixup(struct pci_dev *dev)
> >>  {
> >>         /* PCI fixups are effectively decided compile time. If we have a dual
> >> -          SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
> >> -        if (!pci_soc_mode)
> >> -            return;
> >> +        * SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices.
> >> +        */
> >
> > Please check again Documentation/CodingStyle. Multiline comments
> > should look like this:
> >
> >   /*
> >    * Comment .....
> >    * ...... goes here.
> >    */
> >
> 
> That is exactly what I did. The second line begins with * and comment ends
> on the next line.

Look at the first line.  Daniel's sample has a '/*' by itself.  Yours
contains a whole line of text immediately after the '/*'.

Though in this particular case either form is preferred, depending on
subsystem (IIRC everyone but networking uses Daniel's version).

Vlad


More information about the firefly mailing list